Stop buffering when the request is larger than SecRequestBodyLimit in ProcessPartial mode #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in ProcessPartial mode
Contributor
Author
|
Are there any thoughts on this pull request? |
zimmerle
force-pushed
the
master
branch
2 times, most recently
from
e516f4c to
84f2299
Compare
zimmerle
pushed a commit
that referenced
this pull request
Jan 25, 2016
Contributor
|
Hi @justintime32, thank you for the patch. Finally merged. It will be released as part of v2.9.1 |
This was referenced Jan 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should address #705. It will cause ModSec to stop buffering the incoming request body if it is larger than the configured request limit and in ProcessPartial mode. It will not send an EOS bucket in the forwarding phase of the input filter if it did not read an EOS bucket.
A side effect of handling buffering like this is that request body parsers will sometimes throw errors if they cannot see all of the request data.